add min-age option to mt-index-cat #1064
Conversation
|
That's great. Should we add such a parameter to |
cmd/mt-index-cat/main.go
Outdated
| if minAge != "0" { | ||
| minAgeInt, err := dur.ParseNDuration(minAge) | ||
| perror(err) | ||
| cutoffMin = int64(time.Now().Unix() - int64(minAgeInt)) |
There was a problem hiding this comment.
would it make sense to only call time.Now().Unix() once and then reuse the returned value for the calculation of cutoff and cutoffMin? I know that in reality they're probably only going to be microseconds apart, but I think it's kind of unexpected that theoretically it would be possible that the time-range which is returned by this utility is not exactly cutoffMin - cutoff.
why? is there a use case for it? |
Dieterbe
force-pushed
the
mt-index-cat-min-age
branch
from
ac8fbb6 to
c31344b
Compare
|
PTAL |
|
i am confused by what these min/max age settings actually do. The descriptions of the options are not very clear. I feel that the term "age" is not appropriate for these settings. Age suggests that it is the time since the series was created, which is not what it does. max-age seems to be the equivalent of max-stale setting in MT which i think is a better name and has a much clearer description. So i think we should change these names and descriptions. max-stale: exclude series that have not been seen for this much time. |
|
yes! something also didn't feel quite right to me, and you phrased it very well. |
|
mergey mergey? |
No description provided.