Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Go1.11 #1045

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Go1.11 #1045

merged 2 commits into from
Sep 14, 2018

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Sep 13, 2018

note that for a smooth dev workflow, this means MT developers should also upgrade to go 1.11 on their system, due to the new gofmt change

@replay
Copy link
Contributor

replay commented Sep 13, 2018

I'm glad they fixed that weirdness in /store/cassandra/config.go. Every time I edited it my vi formatted it correctly when storing. Then I had to reopen the file in nano just to mess up the formatting the way gofmt expected it.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Sep 14, 2018

i agree the new format is better. having to run gofmt -w -s store/cassandra/config.go was annoying

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dieterbe Dieterbe merged commit ca3bc87 into master Sep 14, 2018
@Dieterbe Dieterbe deleted the go1.11 branch September 18, 2018 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants