Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

use different metrics counts for out-of-order and dupliate timestamps #1202

Closed
woodsaj opened this issue Jan 7, 2019 · 1 comment · Fixed by #1288
Closed

use different metrics counts for out-of-order and dupliate timestamps #1202

woodsaj opened this issue Jan 7, 2019 · 1 comment · Fixed by #1288
Assignees
@fkaleo
Milestone
vnext

Comments

@woodsaj
Copy link
Member

woodsaj commented Jan 7, 2019

currently, we discard points and increment tank.metrics_too_old when a point's timestamp is <= lastTs for the same series.

However, it is beneficial to be able to differentiate between old data being sent and duplicate data being sent.

I propose that we add a new metric tank.duplicate_ts so we can maintain separate counts of duplicates vs out-of-order.

see also #1201
@fkaleo fkaleo self-assigned this Apr 15, 2019
@fkaleo fkaleo added this to the vnext milestone Apr 15, 2019
@fkaleo fkaleo mentioned this issue Apr 17, 2019
Closed
fkaleo added a commit that referenced this issue Apr 17, 2019
@fkaleo
Use different metric counts for out-of-order vs duplicate data points:
04a3197 
- New Carbon metric 'tank.discarded.new_value_for_timestamp'
- Prometheus metric 'discarded_samples_total' has a new reason 'new-value-for-timestamp'

Fixes #1201, #1202, #1203
@fkaleo fkaleo mentioned this issue Apr 17, 2019
Merged
@fkaleo
Copy link
Contributor

fkaleo commented Apr 17, 2019

Given discussion in #1201, I suggest we call it tank.discarded.new_value_for_timestamp instead of tank.duplicate_ts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fkaleo fkaleo

Labels
None yet
Projects
None yet
Milestone
vnext
2 participants
@woodsaj @fkaleo