Skip to content

Promtail: Update debian image and use a newer libsystemd - #2957

Merged
slim-bean merged 2 commits into
masterfrom
update-libsystem-dev
Nov 24, 2020
Merged

Promtail: Update debian image and use a newer libsystemd #2957
slim-bean merged 2 commits into
masterfrom
update-libsystem-dev

Conversation

@slim-bean

Copy link
Copy Markdown
Collaborator

Fixes #2792, but really thanks to @fifofonix and others in that thread for doing all the hard work!

@fifofonix

Copy link
Copy Markdown

Apologies if I gave the impression that this was a fully worked out solution @slim-bean.

A key question here, and why I held off submitting a pull request myself, is whether this change will break others who are on older systemd versions and I think unfortunately there is a pretty good chance it will.

This is why I asked a question in the original issue regarding how we think we should be solving for this - should we be aiming for, for example, a version that builds to a specific docker tag aimed at newer systemd versions?

I will test the new version against an older pre-fedora 33 machine now, and get back to you if it crashes out, but even if it doesn't I'm not sure this is going to give me loads of confidence there won't be a regression somewhere.

@fifofonix

Copy link
Copy Markdown

Per comment on issue I have tested against older and newer systemd successfully which is good news. Still not 100% confident that the newer systemd API is backwardly compatible and will work on all old system configurations - but that is probably more of a comment on my lack of understanding of the details here.

@slim-bean

slim-bean commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator Author

Still not 100% confident that the newer systemd API is backwardly compatible

I'm less worried about this, the changes indicate that the journals created with newer files can't be read with older code (which we experienced) however they do not indicate any other kind of backward compatibility which I suspect they would have if this were expected.

Also some testing on our end and yours at least sanity checks that it still works. I am comfortable merging this and if someone upgrades and experiences problems at least the issues is quickly remedied by rolling back to the previous promtail version.

@cyriltovena cyriltovena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment or two around this for future us? LGTM

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2957 (d6557fa) into master (4da505b) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2957      +/-   ##
==========================================
- Coverage   61.88%   61.77%   -0.12%     
==========================================
  Files         182      182              
  Lines       14867    14867              
==========================================
- Hits         9201     9184      -17     
- Misses       4820     4837      +17     
  Partials      846      846              
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/promtail/targets/file/tailer.go 69.52% <0.00%> (-5.72%) ⬇️

@slim-bean
slim-bean merged commit 0b84ef8 into master Nov 24, 2020
@slim-bean
slim-bean deleted the update-libsystem-dev branch November 24, 2020 15:55
rfratto added a commit to rfratto/agent that referenced this pull request Nov 24, 2020
rfratto added a commit to rfratto/agent that referenced this pull request Nov 24, 2020
rfratto added a commit to rfratto/agent that referenced this pull request Jan 8, 2021
rfratto added a commit to grafana-cold-storage/agent that referenced this pull request Jan 8, 2021
* Use a newer libsystemd in Docker containers

Corresponds to grafana/loki#2957

* changelog

* merge apt-get commands to create less layers
mattdurham pushed a commit to grafana-cold-storage/agent that referenced this pull request Nov 11, 2021
* Use a newer libsystemd in Docker containers

Corresponds to grafana/loki#2957

* changelog

* merge apt-get commands to create less layers
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
* use a newer libsystemd which understands compression needed in some of the newer OS distros

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promtail Journald Log Forwarding Not Functioning with systemd v246 (affects FedoraCoreOS / Fedora 33 systems)

5 participants