fix(helm): FOLDER_ANNOTATION in ruler & single-binary #19593
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
There was a problem hiding this comment.
Looks good to me as the feature is extended to distributed and single-binary modes as well, @Jayclifford345 @JStickler could you please have a look ?
| Entries should include a reference to the pull request that introduced the change. | ||
|
|
||
| ## Unreleased | ||
| - [BUGFIX] Set `FOLDER_ANNOTATION` in Distributed and SingleBinary deployments. [#19593](https://github.com/grafana/loki/pull/19593) |
Contributor
There was a problem hiding this comment.
Suggested change
| - [BUGFIX] Set `FOLDER_ANNOTATION` in Distributed and SingleBinary deployments. [#19593](https://github.com/grafana/loki/pull/19593) | |
| - [ENHANCEMENT] Set `FOLDER_ANNOTATION` in Distributed and SingleBinary deployments. [#19593](https://github.com/grafana/loki/pull/19593) |
I believe this could be categorised as enhancement ? since it's not really a bug rather extending the feature to the different deployment modes.
Author
There was a problem hiding this comment.
My reasoning was that the enhancement was #13289, but happy to switch the category - whatever you and other maintainers think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#13289 added a chart value (
sidecar.rules.folderAnnotation) that setsFOLDER_ANNOTATIONon the rules sidecar. However, it only sets that environment variable on loki-backend in SimpleScalable mode.This PR sets
FOLDER_ANNOTATIONeven in SIngleBinary and Distributed deployment modesWhich issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR