feat(engine): rate() aggregate function#19589
Merged
spiridonov merged 10 commits intomainfrom Oct 29, 2025
Merged
Conversation
spiridonov
changed the title
| case syntax.OpRangeTypeRate: | ||
| // rate is implemented as count_over_time/$interval | ||
| builder = builder.BinOpRight(types.BinaryOpDiv, &Literal{ | ||
| Literal: NewLiteral(params.Interval().Seconds()), |
Contributor
There was a problem hiding this comment.
right hand side here should be rangeInterval. For reference:
loki/pkg/logql/range_vector.go
Line 226 in bb07ede
Contributor
There was a problem hiding this comment.
if the query has unwrap along with rate, left side should be sum_over_time or we can mark this as unimplemented for now
Contributor
Author
There was a problem hiding this comment.
Thanks! Did not know about that unwrap with rate. Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds
raterange aggregation ascount_over_time/$interval.Which issue(s) this PR fixes:
https://github.com/grafana/loki-private/issues/2015
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR