-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(helm): allow set topologySpreadConstraints on singleBinary #19534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JStickler
merged 8 commits into
grafana:main
from
mvink-guida:singleBinaryTopologySpreadConstraints
Nov 4, 2025
Merged
feat(helm): allow set topologySpreadConstraints on singleBinary #19534
JStickler
merged 8 commits into
grafana:main
from
mvink-guida:singleBinaryTopologySpreadConstraints
Nov 4, 2025
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, please run |
fbeb853 to
c5859ac
Compare
Done |
Signed-off-by: mvink-guida <[email protected]>
jkroepke
reviewed
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: J Stickler <[email protected]>
Signed-off-by: mvink-guida <[email protected]>
jkroepke
reviewed
Oct 31, 2025
Co-authored-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: mvink-guida <[email protected]>
Signed-off-by: Jay Clifford <[email protected]>
Jayclifford345
approved these changes
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jay Clifford <[email protected]>
Signed-off-by: Jay Clifford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow balance singleBinary replicas when using 3 replicas and objectStorage over just two nodes or zones.
With topologySpreadConstraints you can accomplish affinity just over two topologyKeys and so allow cluster autoscaler to scale back to two nodes/zones, in our case zoneC(or the 3rd node) should stay optional as fallback. With podAntiAffinity you can not accomplish this.
Which issue(s) this PR fixes:
Fixes #10205
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR