Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change pushHandler to return 200 not 204 #15801

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sysadmin1139
Copy link

What this PR does / why we need it:
Changes response-code for the /otlp/v1/logs endpoint to return 200-OK instead of 204-NoContent.

See also:

The 200-OK behavior is per the OTLP specification this endpoint uses.

Which issue(s) this PR fixes:
Fixes #15761

Special notes for your reviewer:
This is a change of behavior from historical, but is in better compliance with the spec.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@sysadmin1139 sysadmin1139 requested a review from a team as a code owner January 16, 2025 19:40
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/v1/logs returns HTTP status 204 when it should return 200
2 participants