refactor!: Merge operational_config into limits_config configuration block
#15762
+738
−930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
|
💻 Deploy preview available: https://deploy-preview-loki-15762-zb444pucvq-vp.a.run.app/docs/loki/latest/ |
chaudum
force-pushed
the
chaudum/rewrite-runtime-config
branch
3 times, most recently
from
6e58309 to
6beca36
Compare
chaudum
changed the title
operational_config into limits_configoperational_config into limits_config configuration block
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/rewrite-runtime-config
branch
from
6beca36 to
6f34a36
Compare
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
periklis
approved these changes
Jan 30, 2025
JStickler
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR unifies how "limits" (per-tenant runtime overrides) are used throughout the code base. The definition of the "limits" moved from
pkg/validationtopkg/runtime.The
operational_confighas been introduced with #12448 together with a separate implementation how per-tenant runtime configuration settings are handled. This lead to inconsistencies in the code base.