chore: Refactor storage interface for rf1 #13415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
approved these changes
Jul 5, 2024
| return store, nil | ||
| } | ||
|
|
||
| func (m *Multi) GetStoreFor(ts model.Time) (client.ObjectClient, error) { |
There was a problem hiding this comment.
Thanks for implementing this - I wasn't sure how it was meant to work with the existing store implementation.
| if rs, ok := r.(io.ReadSeeker); ok { | ||
| return rs, nil | ||
| } | ||
| data, err := io.ReadAll(r) |
There was a problem hiding this comment.
Should we think about a sync.Pool here? Presumably it allocates a new buffer every time
Should be fine for now, we can return to it if it's an issue.
There was a problem hiding this comment.
I think the caller should really pass a ReadSeeker, this is a best effort.
vlad-diachenko
approved these changes
Jul 5, 2024
Comment on lines
+64
to
+66
| if 0 <= j && j < len(m.stores) { | ||
| return m.stores[j].objectClient, nil | ||
| } |
There was a problem hiding this comment.
nit: if the first schema is after the ts, sort.Search() returns 0 , after this we decrease it and it will be -1 that will fail this code.
but it's possible only in case the user misconfigured his schema_config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This refactor the RF1 storage to use io.Reader as much as possible to avoid creating a temporary buffer.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR