-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR #9510 introduces an additional IPv6 listener in gateway which breaks on systems without IPv6 support #9681
Comments
just ran into this issue, using the Helm chart In case it helps others with this problem, I'm currently using the following workaround which attempts to keep as much as possible from the original values to simplify updates in the meantime. Use as values when deploying: gateway:
nginxConfig:
file: |
{{- include "loki.nginxFile" . | replace "listen [::]:8080;" "" | indent 2 -}} |
Does anyone know if this is going to be added as values config option? Maybe there are pull request somewhere in the repo? |
Created a PR to make this configurable in a bit nicer way: #11722 |
**What this PR does / why we need it**: Loki Gateway pod crashes on systems that only have IPv4 enabled since PR #9510 **Which issue(s) this PR fixes**: Fixes #9681 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [x] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) --------- Signed-off-by: Pieter van der Giessen <[email protected]> Co-authored-by: Michel Hollands <[email protected]>
**What this PR does / why we need it**: Loki Gateway pod crashes on systems that only have IPv4 enabled since PR grafana#9510 **Which issue(s) this PR fixes**: Fixes grafana#9681 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [x] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a) --------- Signed-off-by: Pieter van der Giessen <[email protected]> Co-authored-by: Michel Hollands <[email protected]>
**What this PR does / why we need it**: Loki Gateway pod crashes on systems that only have IPv4 enabled since PR grafana#9510 **Which issue(s) this PR fixes**: Fixes grafana#9681 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e) - [x] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a) --------- Signed-off-by: Pieter van der Giessen <[email protected]> Co-authored-by: Michel Hollands <[email protected]>
Describe the bug
PR #9510 introduces an additional IPv6 listener in gateway which fails on systems with single-stack setup (IPv4 only):
Btw. in the Helm charts of Tempo and Mimir is IPv6 not activated by default (yet).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Loki's gateway should run on a IPv4-only system like it does before Helm chart version 5.5.10.
Environment:
grafana/loki
v5.5.10+Screenshots, Promtail config, or terminal output
Gateway / Nginx log:
The text was updated successfully, but these errors were encountered: