Docker Loki Driver ARM64 #5682
Comments
|
I think this is something we'd be open to accepting a PR for, have a look at this in progress PR that's adding arm64 support for another component as an example. |
|
Linking this for reference if anyone else stumbles upon this issue. #1973 is tracking a similar issue but for armv6 and armv7 due to its age (Apr 22, 2020) |
|
+1 |
|
same here. +1 |
|
same here +1 |
5 tasks
|
same here +1 |
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Sep 9, 2023
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
|
we need it badly, too |
|
I ran into some stability issues on arm using the docker driver so I switched over to journald which works very well for my setup. Pasting my config here for reference.
{
"log-driver": "journald",
"log-opts": {
"tag": "{{.Name}}/{{.ID}}"
}
}
scrape_configs:
- job_name: journald
journal:
max_age: 12h
path: /var/log/journal
labels:
job: journald
relabel_configs:
- action: drop
source_labels: [__journal__systemd_unit]
regex: session-.*
- source_labels: [__journal__hostname]
target_label: hostname
- source_labels: [__journal__boot_id]
target_label: boot_id
- source_labels: [__journal__systemd_unit]
target_label: unit
- source_labels: [__journal_priority]
target_label: priority
- source_labels: [__journal_container_name]
target_label: container
- source_labels: [__journal_container_id]
target_label: container_id
- source_labels: [__journal_image_name]
target_label: image
pipeline_stages:
- match:
selector: '{job="journald"} |= ".mount: Deactivated successfully."'
action: drop |
|
@peterhirn loki for us works well, in ARM, too: our issue is that we see it is running in "emulation" with so we are sure this results in performance being pretty bad |
|
Any updates? Hetzner arm servers are amazing, and on each of them playing with bulding the arm64 version of this plugin is tedious. |
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Jul 20, 2024
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Jul 26, 2024
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
|
ping |
|
This is really taking to much... my 2 cents: can the PR #9247 just be accepted and just move on? |
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Oct 4, 2024
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Oct 10, 2024
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Oct 14, 2024
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
tucksaun
added a commit
to tucksaun/loki
that referenced
this issue
Nov 7, 2024
**What this PR does / why we need it**: Add ARM64 build and release of the Docker driver in Drone pipeline **Which issue(s) this PR fixes**: Fixes grafana#5682 **Special notes for your reviewer**: I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not support multi arch images. So instead I went with tweaking the build steps to allow cross building the image for ARM64 and added the instructions to do so in `drone.yml`. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I tried installing the Loki Docker Driver but it doesn't work because it is for AMD64 only at the moment.
Describe the solution you'd like
Adding support for ARM64 and ARM/v7
Can be done by cross compiling even on AMD64
As example via
GOOS=linux GOARCH=arm GOARM=7 go build ./clients/cmd/docker-driverwill build the docker-driver for arm/v7 on AMD64
Describe alternatives you've considered
A Version for ARM64/v8 of the Loki docker plugin is on Docker hub available
miacis/loki-docker-driver
The text was updated successfully, but these errors were encountered: