Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"grafana-agent-operator" depenency chart version is not up to date #11572

Closed
yogeek opened this issue Jan 3, 2024 · 0 comments · Fixed by #11576
Closed

"grafana-agent-operator" depenency chart version is not up to date #11572

yogeek opened this issue Jan 3, 2024 · 0 comments · Fixed by #11576

Comments

@yogeek
Copy link

yogeek commented Jan 3, 2024

Describe the bug
The current latest version (5.41.4) of the production loki chart is using an old version of the "grafana-agent-operator" chart :

- name: grafana-agent-operator
alias: grafana-agent-operator
version: 0.2.16
repository: https://grafana.github.io/helm-charts

This prevents to benefit from some feature like for example the customization of configReloaderImage in the GrafanaAgent CRD.

Is there a specific reason to not update this dependency please ?

Environment:

  • Infrastructure: Kubernetes]
  • Deployment tool: helm
Gordejj pushed a commit to Gordejj/loki that referenced this issue Jan 29, 2024
…rafana#11576)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes grafana#11572 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)
- [ ] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](grafana@0d4416a)

---------

Signed-off-by: Sheikh-Abubaker <[email protected]>
Co-authored-by: Michel Hollands <[email protected]>
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
…rafana#11576)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes grafana#11572 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)
- [ ] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](grafana@0d4416a)

---------

Signed-off-by: Sheikh-Abubaker <[email protected]>
Co-authored-by: Michel Hollands <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
…rafana#11576)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes grafana#11572 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@2cef71e)
- [ ] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](grafana@0d4416a)

---------

Signed-off-by: Sheikh-Abubaker <[email protected]>
Co-authored-by: Michel Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants