Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push latest even for the RC tags #4639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Mar 20, 2025

What?

This change should also unblock labeling the v1.0.0-rc1 as the latest.

Why?

We're going to release v1.0.0-rc1

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@olegbespalov olegbespalov requested a review from a team as a code owner March 20, 2025 16:12
@olegbespalov olegbespalov requested review from mstoykov and codebien and removed request for a team March 20, 2025 16:12
@mstoykov
Copy link
Contributor

I guess this was around to prevent let us have this as a way to test releases.

But I feel like this doesn't work in so many of the otehr cases, that I do not know why we are protecting docker images in particular 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants