Prevent loop when babel can transpile but goja can't parse#1651
Merged
Prevent loop when babel can transpile but goja can't parse#1651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
==========================================
- Coverage 72.16% 72.15% -0.01%
==========================================
Files 166 166
Lines 12787 12787
==========================================
- Hits 9228 9227 -1
+ Misses 3009 3008 -1
- Partials 550 552 +2
Continue to review full report at Codecov.
|
imiric
reviewed
Oct 6, 2020
na--
previously approved these changes
Oct 6, 2020
na--
approved these changes
Oct 6, 2020
imiric
approved these changes
Oct 6, 2020
mstoykov
added a commit
that referenced
this pull request
Nov 17, 2020
This is continuation of PR #1651 as it turns out that sometimes babel doesn't do enough on the first time it runs over some scripts. So let it run twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.