Skip to content

chore: Modernize the Presto Mixin #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: Modernize the Presto Mixin #1491

wants to merge 7 commits into from

Conversation

@schmikei
Copy link
Contributor

@schmikei schmikei commented Oct 10, 2025 •
edited
Loading

Presto overview:

image image

Presto coordinator:

image image

Presto worker:
image
image

Presto logs:
image

@schmikei schmikei marked this pull request as ready for review October 13, 2025 14:28
@schmikei schmikei requested a review from a team as a code owner October 13, 2025 14:28
@schmikei schmikei requested a review from Dasomeone October 13, 2025 14:29
Dasomeone
Dasomeone reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout and structurally looks great to me, just a few panels I think that we can safely convert over to use the premade common-lib components

Dasomeone
Dasomeone approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the pointer on the memory stat panels, the gauge does indeed look better for this usecase

@schmikei schmikei enabled auto-merge (squash) October 28, 2025 15:44
aalhour
aalhour reviewed Oct 29, 2025
View reviewed changes
Copy link

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmikei schmikei disabled auto-merge October 30, 2025 15:06
@schmikei schmikei enabled auto-merge (squash) October 30, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aalhour aalhour aalhour left review comments

@Dasomeone Dasomeone Dasomeone approved these changes

Assignees

No one assigned

Labels

monitoring-mixins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmikei @aalhour @Dasomeone