Apache Mesos Mixin Modernization #1488
Conversation
schmikei
changed the title
…i/jsonnet-libs into chore/apache-mesos-modernization
…pache-mesos-modernization
apache-mesos-mixin/panels.libsonnet
Outdated
| local signals = this.signals, | ||
|
|
||
| masterUptimePanel: | ||
| g.panel.stat.new('Master uptime') |
There was a problem hiding this comment.
Could you update this to use the common-lib stat panel?
Same throughout for any g.panel.stat panels
apache-mesos-mixin/panels.libsonnet
Outdated
| + g.panel.stat.options.withGraphMode('none') | ||
| + g.panel.stat.panelOptions.withDescription('CPUs available in the cluster'), | ||
| memoryAvailablePanel: | ||
| g.panel.stat.new('Memory available') |
There was a problem hiding this comment.
As with the other PRs, can you update the memory panels to use the common lib approach instead of g.panel.stat?
apache-mesos-mixin/panels.libsonnet
Outdated
| + g.panel.stat.panelOptions.withDescription('GPUs available in the cluster'), | ||
|
|
||
| diskAvailablePanel: | ||
| g.panel.stat.new('Disk available') |
There was a problem hiding this comment.
Similarly for all the disk panels, we have common-lib` disk panels https://github.com/grafana/jsonnet-libs/tree/master/common-lib/common/panels/disk that would be great to use
Co-authored-by: Emily <[email protected]>
…i/jsonnet-libs into chore/apache-mesos-modernization
…i/jsonnet-libs into chore/apache-mesos-modernization
apache-mesos-mixin/panels.libsonnet
Outdated
| + g.panel.stat.standardOptions.withUnit('s') | ||
| + g.panel.stat.standardOptions.color.withMode('fixed') | ||
| + g.panel.stat.standardOptions.color.withFixedColor('light-green') | ||
| + g.panel.stat.options.withGraphMode('none') |
There was a problem hiding this comment.
Should be able to delete these lines & similar across all the ones that are common-lib usages.
Unless these are deliberately left here to override the common settings?
There was a problem hiding this comment.
I'll go ahead and delete them 👍 will be easier to apply styles across the board this way
3 participants
Updates the Apache Mesos mixin to use commonlib and g.libsonnet
Apache Mesos overview
Apache Mesos logs overview
Improvement to sample app: grafana/integration-sample-apps#72