Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion from dollar sign: Basic case #79

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Oct 18, 2022

Closes #4

Also:

  • Sort the list of suggestions by label
  • Ignore lines ending with , or ;. This happens when a user is replacing an index in an existing line (refactoring, etc)

Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from julienduchesne/completion-from-imports to main October 20, 2022 16:27
Closes #4

Also:
- Sort the list of suggestions by label
- Ignore lines ending with , or ;. This happens when a user is replacing an index in an existing line (refactoring, etc)
@julienduchesne julienduchesne merged commit f6fe858 into main Oct 20, 2022
@julienduchesne julienduchesne deleted the julienduchesne/dollar-completion branch October 20, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion: $ support
3 participants