On parse failure, keep the old AST #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add a new `linesChangedSinceAST` attribute to the cache. This new attribute contains all lines of a document which have changed since the AST was last parsed This allows us to still use the AST when the file is changed (a WIP is a common use-case) In order to reduce the amount of bad definitions in that case, go-to-definition is only active if the currently targeted line hasn't changed. Otherwise, it's all messed up While this feature is slightly useful for go-to-definition, it'll be absolutely necessary for the completion feature I'm working on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a new
linesChangedSinceASTattribute to the cache. This new attribute contains all lines of a document which have changed since the AST was last parsedThis allows us to still use the AST when the file is changed (a WIP is a common use-case)
In order to reduce the amount of bad definitions in that case, go-to-definition is only active if the currently targeted line hasn't changed. Otherwise, it's all messed up
While this feature is slightly useful for go-to-definition, it'll be absolutely necessary for the completion feature I'm working on