Basic go-to-definition inside functions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing the index list, the language server will now go through function bodies to find fields This will only occur when the function's body is directly a DesugaredObject This doesn't support all cases. I will probably have to add more, I have already identified cases which are even more complex that do not work yet, but this is a good first step
julienduchesne
added a commit
that referenced
this pull request
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing the index list, the language server will now go through function bodies to find fields
This will only occur when the function's body is directly a DesugaredObject
This doesn't support all cases. I will probably have to add more, I have already identified cases which are even more complex that do not work yet, but this is a good first step
In the
go-to-functions-advanced.libsonnetfile, this allows us to find thearg2field accessed later on, even though it's a field created by a function