Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go-to-definition for computed field names. #61

Merged

Conversation

zzehring
Copy link
Contributor

@zzehring zzehring commented Sep 1, 2022

When finding node by position, push field.Name to the search stack.
This allows us to now search through the field names as well when finding
definitions.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2022

CLA assistant check
All committers have signed the CLA.

@zzehring zzehring force-pushed the zzehring/goto-definition-for-computed-field-names branch from 6157b78 to 89ae392 Compare September 1, 2022 22:00
When finding node by position, push `field.Name` to the search stack.
This allows us to now search through the field names as well when finding
definitions.
@zzehring zzehring force-pushed the zzehring/goto-definition-for-computed-field-names branch from 89ae392 to 1933132 Compare September 1, 2022 22:01
@zzehring zzehring marked this pull request as ready for review September 1, 2022 22:02
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, we don't run into those often

@julienduchesne julienduchesne merged commit 945e817 into main Sep 2, 2022
@julienduchesne julienduchesne deleted the zzehring/goto-definition-for-computed-field-names branch September 2, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants