Enable go-to-definition for computed field names. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zzehring
force-pushed
the
zzehring/goto-definition-for-computed-field-names
branch
from
6157b78
to
89ae392
Compare
When finding node by position, push `field.Name` to the search stack. This allows us to now search through the field names as well when finding definitions.
zzehring
force-pushed
the
zzehring/goto-definition-for-computed-field-names
branch
from
89ae392
to
1933132
Compare
julienduchesne
approved these changes
Sep 1, 2022
julienduchesne
deleted the
zzehring/goto-definition-for-computed-field-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finding node by position, push
field.Nameto the search stack.This allows us to now search through the field names as well when finding
definitions.