Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols support #60

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Symbols support #60

merged 3 commits into from
Sep 1, 2022

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Sep 1, 2022 •
edited
Loading

Report symbols to clients of the language server
This allows features like the VSCode outline

In the following screenshots, see the tab in the lower left

image
image

@julienduchesne
Symbols support
5c33044 
Report symbols to clients of the language server
This allows features like the VSCode outline
@julienduchesne
Common LocalBind range parsing
8136899
zzehring
zzehring approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Really like how simple the code is in symbols.go. Just a couple of non-blocking comments.

How extensive are you thinking of building on symbol support? e.g. symbols inside functions.

pkg/server/symbols.go Outdated Show resolved Hide resolved
pkg/server/symbols.go Outdated Show resolved Hide resolved
pkg/server/symbols_test.go Outdated Show resolved Hide resolved
@julienduchesne
Copy link
Member Author

How extensive are you thinking of building on symbol support? e.g. symbols inside functions.

Wasn't sure how confusing it'd be. We can always start like it is now and add an ast.Function case to the switch case if we think it'd be useful

@julienduchesne julienduchesne merged commit c0fdef7 into main Sep 1, 2022
@julienduchesne julienduchesne deleted the julienduchesne/support-symbols branch September 1, 2022 23:46
@julienduchesne julienduchesne mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzehring zzehring zzehring approved these changes

@jdbaldry jdbaldry Awaiting requested review from jdbaldry jdbaldry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienduchesne @zzehring