Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion: Add in parameters when the suggestion is a function #46

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Completion: Add in parameters when the suggestion is a function #46

merged 1 commit into from
Jul 15, 2022

Conversation

julienduchesne
Copy link
Member

Closes #13
This works pretty well out of the box because the args given by the jsonnet docs are valid jsonnet
Ex:
Autocompleting std.manifestYamlDoc will give std.manifestYamlDoc(value, indent_array_in_object=false, quote_keys=true)

@julienduchesne
Completion: Add in parameters when the suggestion is a function
ecbb857 
Closes #13
This works pretty well out of the box because the args given by the jsonnet docs are valid jsonnet
Ex:
Autocompleting `std.manifestYamlDoc` will give `std.manifestYamlDoc(value, indent_array_in_object=false, quote_keys=true)`
zzehring
zzehring approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@zzehring zzehring left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works in Jetbrains (tested in GoLand). I think we could also try to add that functionality that auto-selects the params (not sure what that mechanic is called), saving some extra keystrokes.

@julienduchesne
Copy link
Member Author

julienduchesne commented Jul 15, 2022 •
edited
Loading

LGTM! Works in Jetbrains (tested in GoLand). I think we could also try to add that functionality that auto-selects the params (not sure what that mechanic is called), saving some extra keystrokes.

I don't know if that's a feature of the language server. Didn't find it. I would've liked that also

@julienduchesne julienduchesne merged commit 622645f into main Jul 15, 2022
@julienduchesne julienduchesne deleted the julienduchesne/add-parameters branch July 15, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzehring zzehring zzehring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completion: Add in parameters when the suggestion is a function
2 participants
@julienduchesne @zzehring