Global cache for documents + top level jsonnet objects #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #133 There are two caches currently: - One for protocol documents. This one is instantiated by the server and maintained up-to-date as documents are opened, changed, and closed. - One for jsonnet objects. This one is a global var and is only added to. Modified objects are never removed/modified from the cache. By merging the two caches, we can expand the first cache's behavior to also invalidate modified objects from the global cache when a document is changed.
Instead of carrying a `cache` and `vm` around on each function, create a `Processor` struct to contain those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133
There are two caches currently:
By merging the two caches, we can expand the first cache's behavior to also invalidate modified objects from the global cache when a document is changed.