Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hover on all tokens #152

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Support hover on all tokens #152

merged 2 commits into from
Aug 7, 2024

Conversation

julienduchesne
Copy link
Member

Closes #8
Closes #9
Closes #10

Next step will be to support docsonnet: #109 to get some proper descriptions

@julienduchesne
Support hover on all tokens
d09c7f3 
Closes #8
Closes #9
Closes #10

Next step will be to support docsonnet: #109 to get some proper descriptions
Duologic
Duologic approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see tests, can say code doesn't look unsafe 👍

@julienduchesne julienduchesne merged commit 4c756e3 into main Aug 7, 2024
4 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/support-hover branch August 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duologic Duologic Duologic approved these changes

@jdbaldry jdbaldry Awaiting requested review from jdbaldry jdbaldry is a code owner

@zzehring zzehring Awaiting requested review from zzehring zzehring is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover: Support fields from imported files Hover: $ support Hover: self support
2 participants
@julienduchesne @Duologic