fix(completion): use upstream go-jsonnet Formatter #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
commented
Mar 11, 2024
Comment on lines
+168
to
+170
| interStr := "interimPath" + str | ||
| fmtStr, _ := formatter.Format("", interStr, formatter.DefaultOptions()) | ||
| ret, _ := strings.CutPrefix(fmtStr, "interimPath") |
There was a problem hiding this comment.
This tricks the formatter into thinking it is formatting an ast.Index path, without interimPath, it would be formatting ['something'] as an array instead.
This comment was marked as resolved.
This comment was marked as resolved.
Duologic
requested review from
julienduchesne,
jdbaldry and
zzehring
as code owners
Duologic
commented
Mar 11, 2024
| } | ||
| func formatLabel(str string) string { | ||
| interStr := "interimPath" + str | ||
| fmtStr, _ := formatter.Format("", interStr, formatter.DefaultOptions()) |
There was a problem hiding this comment.
I wonder if we somehow should pass along the formatter options that the LSP already knows of. Also not sure how that would work.
|
I've been using this branch for a little bit but seems something is not entirely correct in some cases. I'll draft it for now. |
Duologic
force-pushed
the
duologic/correcter_quote_completion
branch
from
dead763
to
93cd2e2
Compare
Duologic
force-pushed
the
duologic/correcter_quote_completion
branch
from
93cd2e2
to
c000fa6
Compare
|
Removed the last commit about using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #136, this uses the upstream go-jsonnet formatter. It still feels a bit dirty but I feel much more confident that this will result in correct behavior.