Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double completion bug #124

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

julienduchesne
Copy link
Member

woops
Closes #122

@julienduchesne julienduchesne marked this pull request as ready for review August 29, 2023 02:37
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes it for one of my use cases, but I have one more that still shows doubles with this PR.

@Duologic
Copy link
Member

Duologic commented Aug 29, 2023

And I can now reproduce it, just need one more import layer 😿

local g = import 'hello3.jsonnet';

{
  a: g.hello.<tab>,
}
// hello.jsonnet
{
  hello: {
    to: {
      the: 'world',
    },
  },
}
// hello2.jsonnet
{ hello: (import 'hello.jsonnet').hello }
// hello3.jsonnet
import 'hello2.jsonnet'

@julienduchesne julienduchesne force-pushed the julienduchesne/fix-double-completion-bug branch from f508226 to b6e30b0 Compare August 31, 2023 18:05
@julienduchesne julienduchesne merged commit aebe161 into main Aug 31, 2023
4 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/fix-double-completion-bug branch August 31, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double completion ends up with wrong result
2 participants