Fix world's slowest stack overflow #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with CRDsonnet libraries in our (Grafana Labs) repositories, the language server would lock up: - I thought it had something to do with CRDsonnet but I was wrong. - This happened because it was trying to find a field in the wrong nodestack repeatedly (see image) - This PR fixes the issue. - Obviously, the language server can't find fields that come from processing jsonschema, but at least it doesn't take up 4 full CPUs (it reached a full 1% CPU usage while testing :) )
All tests are still passing. `$` can be resolved across multiple files, so I guess the language server is just better now and doesn't need that safety If this causes a bug, we should add a new test
Duologic
approved these changes
Aug 29, 2023
|
😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with CRDsonnet libraries in our (Grafana Labs) repositories, the language server would lock up and use up all my CPU: