Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion: Fix two issues with local vars #117

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Completion: Fix two issues with local vars #117

merged 3 commits into from
Aug 23, 2023

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Aug 22, 2023 •
edited
Loading

Closes #114
Closes #115

This also fixes the go-to-definition functionality for this case, since it's the same code

I still have #113 to fix but I'll do it in another PR

@julienduchesne
Completion: Fix two issues with local vars
1564a3a 
Closes #114
Closes #115

I still have #113 to fix but I'll do it in another PR
Duologic
Duologic approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine! :)

@julienduchesne julienduchesne merged commit 92fc191 into main Aug 23, 2023
3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/fix-completion-1 branch August 23, 2023 14:22
@graelo graelo mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duologic Duologic Duologic approved these changes

@jdbaldry jdbaldry Awaiting requested review from jdbaldry jdbaldry is a code owner

@zzehring zzehring Awaiting requested review from zzehring zzehring is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@julienduchesne @Duologic