[grafana] fix: only skip init request on init k8s-sidecar#4088
Merged
jkroepke merged 1 commit intografana:mainfrom Jan 15, 2026
Merged
[grafana] fix: only skip init request on init k8s-sidecar#4088jkroepke merged 1 commit intografana:mainfrom
jkroepke merged 1 commit intografana:mainfrom
Conversation
mjnagel
requested review from
QuentinBisson,
Xtigyro,
jkroepke,
maorfr and
torstenwalter
as code owners
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
mjnagel
force-pushed
the
fix-k8s-sidecar-init
branch
from
045a7e3 to
4639f9d
Compare
cwrau
added a commit
to teutonet/teutonet-helm-charts
that referenced
this pull request
Jan 16, 2026
This has been fixed in grafana/helm-charts#4088, which has been released as 10.5.8, which is in this kube-prometheus-stack version
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`10.5.8\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.8) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: only skip init request on init k8s-sidecar by [@mjnagel](https://github.com/mjnagel) in [#4088](grafana/helm-charts#4088) **Full Changelog**: <grafana/helm-charts@grafana-10.5.7...grafana-10.5.8> --- ##### [\`10.5.7\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.7) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: Use PV name when supplied, rather than looking up existing PVC v… by [@aimmac23](https://github.com/aimmac23) in [#4086](grafana/helm-charts#4086) #### New Contributors - [@aimmac23](https://github.com/aimmac23) made their first contribution in [#4086](grafana/helm-charts#4086) **Full Changelog**: <grafana/helm-charts@grafana-10.5.6...grafana-10.5.7> --- ##### [\`10.5.6\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.6) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Allow customization of hostUsers by [@jcpunk](https://github.com/jcpunk) in [#4082](grafana/helm-charts#4082) **Full Changelog**: <grafana/helm-charts@k8s-monitoring-3.7.2...grafana-10.5.6> --- ##### [\`10.5.5\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.5) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix(unified): set default index\_path in chart by [@RafaelPaulovic](https://github.com/RafaelPaulovic) in [#4080](grafana/helm-charts#4080) **Full Changelog**: <grafana/helm-charts@grafana-10.5.4...grafana-10.5.5>
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`10.5.8\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.8) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: only skip init request on init k8s-sidecar by [@mjnagel](https://github.com/mjnagel) in [#4088](grafana/helm-charts#4088) **Full Changelog**: <grafana/helm-charts@grafana-10.5.7...grafana-10.5.8> --- ##### [\`10.5.7\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.7) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: Use PV name when supplied, rather than looking up existing PVC v… by [@aimmac23](https://github.com/aimmac23) in [#4086](grafana/helm-charts#4086) #### New Contributors - [@aimmac23](https://github.com/aimmac23) made their first contribution in [#4086](grafana/helm-charts#4086) **Full Changelog**: <grafana/helm-charts@grafana-10.5.6...grafana-10.5.7> --- ##### [\`10.5.6\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.6) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Allow customization of hostUsers by [@jcpunk](https://github.com/jcpunk) in [#4082](grafana/helm-charts#4082) **Full Changelog**: <grafana/helm-charts@k8s-monitoring-3.7.2...grafana-10.5.6> --- ##### [\`10.5.5\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.5) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix(unified): set default index\_path in chart by [@RafaelPaulovic](https://github.com/RafaelPaulovic) in [#4080](grafana/helm-charts#4080) **Full Changelog**: <grafana/helm-charts@grafana-10.5.4...grafana-10.5.5>
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`10.5.8\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.8) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: only skip init request on init k8s-sidecar by [@mjnagel](https://github.com/mjnagel) in [#4088](grafana/helm-charts#4088) **Full Changelog**: <grafana/helm-charts@grafana-10.5.7...grafana-10.5.8> --- ##### [\`10.5.7\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.7) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: Use PV name when supplied, rather than looking up existing PVC v… by [@aimmac23](https://github.com/aimmac23) in [#4086](grafana/helm-charts#4086) #### New Contributors - [@aimmac23](https://github.com/aimmac23) made their first contribution in [#4086](grafana/helm-charts#4086) **Full Changelog**: <grafana/helm-charts@grafana-10.5.6...grafana-10.5.7> --- ##### [\`10.5.6\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.6) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Allow customization of hostUsers by [@jcpunk](https://github.com/jcpunk) in [#4082](grafana/helm-charts#4082) **Full Changelog**: <grafana/helm-charts@k8s-monitoring-3.7.2...grafana-10.5.6> --- ##### [\`10.5.5\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.5) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix(unified): set default index\_path in chart by [@RafaelPaulovic](https://github.com/RafaelPaulovic) in [#4080](grafana/helm-charts#4080) **Full Changelog**: <grafana/helm-charts@grafana-10.5.4...grafana-10.5.5>
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 20, 2026
##### [\`10.5.8\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.8) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: only skip init request on init k8s-sidecar by [@mjnagel](https://github.com/mjnagel) in [#4088](grafana/helm-charts#4088) **Full Changelog**: <grafana/helm-charts@grafana-10.5.7...grafana-10.5.8> --- ##### [\`10.5.7\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.7) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: Use PV name when supplied, rather than looking up existing PVC v… by [@aimmac23](https://github.com/aimmac23) in [#4086](grafana/helm-charts#4086) #### New Contributors - [@aimmac23](https://github.com/aimmac23) made their first contribution in [#4086](grafana/helm-charts#4086) **Full Changelog**: <grafana/helm-charts@grafana-10.5.6...grafana-10.5.7> --- ##### [\`10.5.6\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.6) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Allow customization of hostUsers by [@jcpunk](https://github.com/jcpunk) in [#4082](grafana/helm-charts#4082) **Full Changelog**: <grafana/helm-charts@k8s-monitoring-3.7.2...grafana-10.5.6> --- ##### [\`10.5.5\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.5) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix(unified): set default index\_path in chart by [@RafaelPaulovic](https://github.com/RafaelPaulovic) in [#4080](grafana/helm-charts#4080) **Full Changelog**: <grafana/helm-charts@grafana-10.5.4...grafana-10.5.5>
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 20, 2026
##### [\`10.5.8\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.8) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: only skip init request on init k8s-sidecar by [@mjnagel](https://github.com/mjnagel) in [#4088](grafana/helm-charts#4088) **Full Changelog**: <grafana/helm-charts@grafana-10.5.7...grafana-10.5.8> --- ##### [\`10.5.7\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.7) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix: Use PV name when supplied, rather than looking up existing PVC v… by [@aimmac23](https://github.com/aimmac23) in [#4086](grafana/helm-charts#4086) #### New Contributors - [@aimmac23](https://github.com/aimmac23) made their first contribution in [#4086](grafana/helm-charts#4086) **Full Changelog**: <grafana/helm-charts@grafana-10.5.6...grafana-10.5.7> --- ##### [\`10.5.6\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.6) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Allow customization of hostUsers by [@jcpunk](https://github.com/jcpunk) in [#4082](grafana/helm-charts#4082) **Full Changelog**: <grafana/helm-charts@k8s-monitoring-3.7.2...grafana-10.5.6> --- ##### [\`10.5.5\`](https://github.com/grafana/helm-charts/releases/tag/grafana-10.5.5) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] fix(unified): set default index\_path in chart by [@RafaelPaulovic](https://github.com/RafaelPaulovic) in [#4080](grafana/helm-charts#4080) **Full Changelog**: <grafana/helm-charts@grafana-10.5.4...grafana-10.5.5>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
REQ_SKIP_INITfrom the environment variables when the k8s-sidecar is run as a sidecar (rather than init container) to prevent race conditions around Grafana startup and the k8s-sidecar startup (see here).REQ_SKIP_INITcan only be safely used if we can guarantee start order of the containers. This is only the case withinitContainers, and more specifically if they have proper probes for startup/readiness (to ensure the container has "actually started"). Otherwise you end up with a situation where the request to Grafana is skipped even if the sidecar did not startup/create a datasource/dashboard file first.Resolves #4031