[loki-distributed] Add sidecar container for loki ruler to fetch AlertingRules from Configmaps/Secrets #2900
Conversation
…igmaps/Secrets Signed-off-by: mbeczkowski <[email protected]>
|
|
|
Hi guys, any news on this feature? |
|
@zalegrala Can you help with this PR please? |
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: mbec-printify <[email protected]>
|
@Sheikh-Abubaker Do you have permission to approve this PR? |
Yes I have, is this feature tested properly ? |
|
Can we somehow unblock this please? It's a pity that Loki supports pull based alerts but we need to patch things manually because of an open PR :) |
|
+1 it's getting silly now |
Signed-off-by: MH <[email protected]>
|
any news? |
|
I've not reviewed the change change, but I would offer that, considering the lack of attention on the loki-distirbuted chart, it may be prudent to use a chart which gets more support, updates, and attention. As mentioned in the OP, the change has been merged in the |
|
there's a reason this chart is being used, in you would be surprised how complex places... this change has also been battle tested for over a year now, we just have to jump through hoops every upgrade which is annoying, considering the effort PR requestor made here |
|
Understood @gacopl. Please don't shoot the messenger. I imagine switching charts to be something of a chore considering potential complexity. What I'm offering by way of suggestion, is that some charts get more review from the folks who know best. |
|
Sorry didn't mean to be mean :D it's just someone made the legwork to add this in multiple charts and for some reason we're have issue only with the one we care the most :D |
| # -- Label value that the configmaps/secrets with rules will be set to. | ||
| labelValue: "" | ||
| # -- Folder into which the rules will be placed. | ||
| folder: /etc/loki/sc-rules |
There was a problem hiding this comment.
Should this reference the variable?
| type: local | ||
| local: | ||
| directory: /etc/loki/rules | ||
| directory: {{ if .Values.ruler.sidecar.enabled }}/etc/loki/sc-rules{{ else }}/etc/loki/rules{{ end }} |
There was a problem hiding this comment.
If the sidecar is enabled, could it just mount at the exiting path instead of a new path?
There was a problem hiding this comment.
Closing in favor of #3975 Thanks for your contribution! feel free to explore the issues and contribute to charts which are actively being maintained.
10 participants
PR Description
Already done in those 2 PRs for legacy repo & current loki Helm chart. I've migrated the above solution to the loki-distributed Helm chart and tested locally with prom-stack.
What this PR does:
PR adds a sidecar container to the Ruler deployment to fetch alerting rules defined in separate ConfigMaps and Secrets (based on k8s labels).
The goal of this update is to enable the creation of AlertingRules independently for other services deployments. With this setup, services can manage their own alerting rules in a self-contained manner, through individual ConfigMaps or Secrets, without directly interfacing with the primary ruler deployment.
Checklist