Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: correct verify script #18236

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Build: correct verify script #18236

merged 1 commit into from
Jul 23, 2019

Conversation

markelog
Copy link
Contributor

Follow-up for 4b16cd6

@markelog markelog requested a review from xlson July 23, 2019 13:19
Copy link
Contributor

@xlson xlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@markelog markelog merged commit ba46cf4 into master Jul 23, 2019
@markelog markelog added this to the 6.3.0-beta2 milestone Jul 23, 2019
ryantxu added a commit that referenced this pull request Jul 23, 2019
* origin/master:
  Replaced ubuntu:latest with ubuntu:18.04; specific image version to make grafana build images consistent (#18224)
  Build: correct verify script (#18236)
  remote_cache: Fix redis connstr parsing (#18204)
  Auth: do not expose disabled user disabled status (#18229)
  Build: Introduce shellcheck (#18081)
  Docs: Update documentation with new SAML features (#18163)
@markelog markelog removed this from the 6.3.0-beta2 milestone Jul 26, 2019
@xlson xlson added this to the 6.3.0-beta3 milestone Aug 1, 2019
xlson pushed a commit to xlson/grafana that referenced this pull request Aug 2, 2019
Follow-up for 4b16cd6

(cherry picked from commit ba46cf4)
xlson pushed a commit that referenced this pull request Aug 2, 2019
Follow-up for 4b16cd6

(cherry picked from commit ba46cf4)
@markelog markelog deleted the shellcheck-follow-up branch August 2, 2019 19:23
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants