Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @grafana/eslint-plugin-plugins to all examples #464

Merged
merged 27 commits into from
Feb 11, 2025

Conversation

hugohaggmark
Copy link
Contributor

@hugohaggmark hugohaggmark commented Feb 10, 2025

This PR adds @grafana/eslint-plugin-plugins package and changes ESLint config in order to get results for @grafana/eslint-plugin-plugins

Moved the ESLint warnings/errors here: https://github.com/orgs/grafana/projects/76/views/4?sliceBy%5Bvalue%5D=hugohaggmark&pane=issue&itemId=97184296&issue=grafana%7Cgrafana-community-team%7C338

Partially fixes #337

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hugohaggmark hugohaggmark changed the title Hugoh/add eslint plugin Adds @grafana/eslint-plugin-plugins package Feb 10, 2025
@hugohaggmark hugohaggmark changed the title Adds @grafana/eslint-plugin-plugins package Adds @grafana/eslint-plugin-plugins to all examples Feb 10, 2025
@hugohaggmark hugohaggmark self-assigned this Feb 10, 2025
@hugohaggmark hugohaggmark marked this pull request as ready for review February 10, 2025 06:45
@hugohaggmark hugohaggmark requested review from a team as code owners February 10, 2025 06:45
@hugohaggmark hugohaggmark requested review from oshirohugo and wbrowne and removed request for a team February 10, 2025 06:45
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@hugohaggmark
Copy link
Contributor Author

hugohaggmark commented Feb 11, 2025

So I also fixed a bunch of ESLint warnings and an ESLint error in this PR, please have a look @leventebalogh and see if this looks ok, thank you 🙏

@hugohaggmark hugohaggmark requested a review from jackw February 11, 2025 10:18
@hugohaggmark
Copy link
Contributor Author

I added you as well to this @jackw 👍

Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work @hugohaggmark! 👏

@hugohaggmark hugohaggmark merged commit 803d41d into main Feb 11, 2025
21 checks passed
@hugohaggmark hugohaggmark deleted the hugoh/add-eslint-plugin branch February 11, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

3 participants