-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds @grafana/eslint-plugin-plugins to all examples #464
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀
So I also fixed a bunch of ESLint warnings and an ESLint error in this PR, please have a look @leventebalogh and see if this looks ok, thank you 🙏 |
I added you as well to this @jackw 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice work @hugohaggmark! 👏
This PR adds
@grafana/eslint-plugin-plugins
package and changes ESLint config in order to get results for@grafana/eslint-plugin-plugins
Moved the ESLint warnings/errors here: https://github.com/orgs/grafana/projects/76/views/4?sliceBy%5Bvalue%5D=hugohaggmark&pane=issue&itemId=97184296&issue=grafana%7Cgrafana-community-team%7C338
Partially fixes #337