Skip to content

fix(grafana): delete dangling ingress#2298

Merged
weisdd merged 2 commits intomasterfrom
fix/dangling-ingress
Nov 15, 2025
Merged

fix(grafana): delete dangling ingress#2298
weisdd merged 2 commits intomasterfrom
fix/dangling-ingress

Conversation

@weisdd
Copy link
Copy Markdown
Collaborator

@weisdd weisdd commented Nov 15, 2025

  • grafana:
    • there's an old well-known issue in the grafana controller where it does not attempt to delete an Ingress when someone nullifies the ingress spec in the Grafana CR (.spec.ingress = {} -> .spec.ingress = nil), the PR intends to fix that:
      • as, at the moment, we allow users to pick only a single ingress resource type, I've put the clean up logic outside of the reconcileIngress function;
      • if we agree on the implementation, we can add similar logic for other ingress resource types.

@github-actions github-actions Bot added the bugfix this PR fixes a bug label Nov 15, 2025
Copy link
Copy Markdown
Collaborator

@Baarsgaard Baarsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I assume we have a similar issue for OpenShift routes then?

@weisdd
Copy link
Copy Markdown
Collaborator Author

weisdd commented Nov 15, 2025

@Baarsgaard yeah, we do :)

@weisdd weisdd force-pushed the fix/dangling-ingress branch from d9336d2 to 09378dd Compare November 15, 2025 13:22
@weisdd weisdd enabled auto-merge November 15, 2025 13:26
@weisdd weisdd added this pull request to the merge queue Nov 15, 2025
@weisdd
Copy link
Copy Markdown
Collaborator Author

weisdd commented Nov 15, 2025

I'll open a separate PR for dangling Routes soon. With #2300 merged, we can easily test the behaviour.

Merged via the queue into master with commit 6450b6b Nov 15, 2025
16 checks passed
@weisdd weisdd deleted the fix/dangling-ingress branch November 15, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix this PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants