Skip to content

Conversation

vignesh-codes
Copy link
Contributor

Description
Added reconcile logic for secrets using .Owns in serviceaccount_controller

Related Issue
#2178 (comment)

What Changed

@github-actions github-actions bot added the feature this PR introduces a new feature label Sep 25, 2025
@Baarsgaard Baarsgaard self-requested a review September 25, 2025 09:14
Copy link
Collaborator

@Baarsgaard Baarsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally clicked approve 😅

Copy link
Collaborator

@Baarsgaard Baarsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this, I noticed that as long as the secret exists, the operator would consider it valid.
I added some rudimentary checks to ensure the secret at least "looks right" after an update.
If not, it's disqualified and recreated by the operator.

@Baarsgaard Baarsgaard added this pull request to the merge queue Sep 29, 2025
@Baarsgaard
Copy link
Collaborator

Thanks for another great contribution 😄

Merged via the queue into grafana:master with commit addf893 Sep 29, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature this PR introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants