Address PR #1 review, add Renovate auto-update docs#3
Conversation
- Remove FIX_JSONC_PRETTIER flag from super-linter.env to fix inconsistency with disabled VALIDATE_JSON_PRETTIER - Add error handling in renovate-deps.py for missing renovate-tracked-deps.json file - Split long EXCLUDED_MANAGERS line in renovate-deps.py into multiple lines for readability - Update CHANGELOG.md to document v0.1.0 release Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
- Add logic to create renovate-tracked-deps.json when AUTOFIX=true and file doesn't exist - Keep EXCLUDED_MANAGERS on single line per Ruff formatter preference, with linter suppressions Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses review feedback from PR #1 and adds documentation for automatic Renovate version updates. It fixes a bug in the renovate-deps linter where it would crash if the tracked-deps file doesn't exist, removes a duplicate configuration entry from super-linter settings, and documents how consuming repositories can configure Renovate to automatically update their pinned flint versions.
Changes:
- Fixed AUTOFIX handling in renovate-deps linter to create the tracking file instead of crashing when it doesn't exist
- Removed duplicate
FIX_JSONC_PRETTIERfrom super-linter configuration (conflicts with Biome-based JSON formatting) - Added CHANGELOG entry for v0.1.0 release
- Documented Renovate custom manager regex for automatic flint version updates in consuming repos
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tasks/lint/renovate-deps.py | Added file existence check with autofix support to handle first-time file creation |
| README.md | Added documentation section explaining how to configure Renovate to auto-update flint versions via custom regex manager |
| CHANGELOG.md | Added v0.1.0 release entry with date and version comparison links |
| .github/config/super-linter.env | Removed duplicate FIX_JSONC_PRETTIER that conflicts with Biome-based JSON formatting strategy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with open(COMMITTED, "w", encoding="utf-8") as f: | ||
| json.dump(generated_data, f, indent=2) | ||
| f.write("\n") |
There was a problem hiding this comment.
Consider adding directory creation to handle edge cases where .github doesn't exist yet. You can use COMMITTED.parent.mkdir(parents=True, exist_ok=True) before opening the file for writing. While .github should typically exist in repos using this tool, being defensive can prevent unexpected failures.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Summary
renovate-tracked-deps.jsondoesn't exist yet (creates the file instead of crashing)FIX_JSONC_PRETTIERfrom super-linter envTest plan
lint:renovate-depswithAUTOFIX=trueworks whenrenovate-tracked-deps.jsondoesn't existlint:renovate-depswithoutAUTOFIXfails gracefully when file is missingraw.githubusercontent.comURLs