Skip to content

fix(renovate): support block-scalar mise sha256 values#266

Merged
zeitlinger merged 1 commit intomainfrom
codex/renovate-sha256-block-scalar
May 6, 2026
Merged

fix(renovate): support block-scalar mise sha256 values#266
zeitlinger merged 1 commit intomainfrom
codex/renovate-sha256-block-scalar

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

What changed

This updates the Renovate mise-action custom-manager regex to accept both plain sha256: scalars and YAML block-scalar forms such as sha256: >- followed by the digest on the next indented line.

It also mirrors the same matcher update in the repository's own .github/renovate.json5 and adds a regression test that compiles the stored regex and verifies both YAML layouts.

Why

A ryl rewrite changed the YAML line style for sha256, which caused the existing regex to stop matching the mise-action stanza. Once that happened, the Renovate update rule no longer tracked the digest reliably.

Impact

This makes the shared preset and the repo-local Renovate config more resilient to equivalent YAML scalar styles without broadening the accepted digest format beyond a 64-character lowercase SHA-256.

Validation

  • cargo test
  • mise run lint:fix
  • mise run lint

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger marked this pull request as ready for review May 6, 2026 07:41
@zeitlinger zeitlinger requested a review from a team as a code owner May 6, 2026 07:41
Copilot AI review requested due to automatic review settings May 6, 2026 07:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Renovate mise-action custom-manager regex used by Flint’s shared Renovate preset (default.json) and the repo-local Renovate config (.github/renovate.json5) so it matches both plain sha256: scalars and YAML block-scalar forms (e.g., sha256: >- with the digest on the next indented line). It also adds a Rust regression test to ensure the stored regex compiles and matches both layouts.

Changes:

  • Broadened the mise-action Renovate regex to accept optional YAML block-scalar indicators while keeping the digest constraint at exactly 64 lowercase hex chars.
  • Mirrored the same regex update in .github/renovate.json5 to prevent drift from the shared preset.
  • Added a unit test that compiles the regex from default.json and asserts it captures both the version and digest for plain vs block-scalar YAML samples.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/registry/tests.rs Adds a regression test that compiles the stored Renovate regex and validates matching/capture behavior for both YAML scalar styles.
default.json Updates the shared Renovate preset’s mise-action custom-manager regex to accept block-scalar sha256 values.
.github/renovate.json5 Mirrors the same mise-action regex update in the repo-local Renovate config to stay aligned with default.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zeitlinger zeitlinger merged commit aab6fbd into main May 6, 2026
18 checks passed
@zeitlinger zeitlinger deleted the codex/renovate-sha256-block-scalar branch May 6, 2026 09:12
This was referenced May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants