fix(renovate): support block-scalar mise sha256 values#266
Merged
zeitlinger merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Renovate mise-action custom-manager regex used by Flint’s shared Renovate preset (default.json) and the repo-local Renovate config (.github/renovate.json5) so it matches both plain sha256: scalars and YAML block-scalar forms (e.g., sha256: >- with the digest on the next indented line). It also adds a Rust regression test to ensure the stored regex compiles and matches both layouts.
Changes:
- Broadened the
mise-actionRenovate regex to accept optional YAML block-scalar indicators while keeping the digest constraint at exactly 64 lowercase hex chars. - Mirrored the same regex update in
.github/renovate.json5to prevent drift from the shared preset. - Added a unit test that compiles the regex from
default.jsonand asserts it captures both the version and digest for plain vs block-scalar YAML samples.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/registry/tests.rs |
Adds a regression test that compiles the stored Renovate regex and validates matching/capture behavior for both YAML scalar styles. |
default.json |
Updates the shared Renovate preset’s mise-action custom-manager regex to accept block-scalar sha256 values. |
.github/renovate.json5 |
Mirrors the same mise-action regex update in the repo-local Renovate config to stay aligned with default.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martincostello
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the Renovate
mise-actioncustom-manager regex to accept both plainsha256:scalars and YAML block-scalar forms such assha256: >-followed by the digest on the next indented line.It also mirrors the same matcher update in the repository's own
.github/renovate.json5and adds a regression test that compiles the stored regex and verifies both YAML layouts.Why
A
rylrewrite changed the YAML line style forsha256, which caused the existing regex to stop matching themise-actionstanza. Once that happened, the Renovate update rule no longer tracked the digest reliably.Impact
This makes the shared preset and the repo-local Renovate config more resilient to equivalent YAML scalar styles without broadening the accepted digest format beyond a 64-character lowercase SHA-256.
Validation
cargo testmise run lint:fixmise run lint