fix(mise): migrate flint-managed tools to supported backends#258
Merged
zeitlinger merged 9 commits intomainfrom May 6, 2026
Merged
fix(mise): migrate flint-managed tools to supported backends#258zeitlinger merged 9 commits intomainfrom
zeitlinger merged 9 commits intomainfrom
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
22dde89 to
8c2befe
Compare
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
8c2befe to
7e0f7f8
Compare
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates Flint-managed mise.toml tool keys away from backend-specific identifiers (e.g. github:*) toward supported registry/native keys, while preserving an explicit migration path so flint-setup can automatically rewrite existing repos. It also updates CI/scaffolding to a newer mise release required for the new registry coverage.
Changes:
- Migrate Flint-managed tool keys to supported identifiers (e.g.
shellcheck,google-java-format,aqua:*) and mark legacy keys as obsolete for automated rewriting. - Update registry logic/tests, README snippets, Renovate metadata, and fixtures to reflect the new canonical keys.
- Bump GitHub Actions
misesetup tov2026.5.0and update the standalone-binary SHA256 values used byjdx/mise-action.
Reviewed changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cases/xmllint/failure/files/mise.toml | Update xmloxide tool key fixture to aqua:*. |
| tests/cases/xmllint/clean/files/mise.toml | Update xmloxide tool key fixture to aqua:*. |
| tests/cases/shellcheck/sourced-file/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/shellcheck/failure/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/shellcheck/config-dir/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/shellcheck/clean/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/google-java-format/failure/files/mise.toml | Update google-java-format fixture to bare key. |
| tests/cases/google-java-format/clean/files/mise.toml | Update google-java-format fixture to bare key. |
| tests/cases/google-java-format/auto-fix/files/mise.toml | Update google-java-format fixture to bare key. |
| tests/cases/general/unsupported-alternate-config/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/time-flag/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/init-idempotent/test.toml | Adjust init expected output to new normalization/hook messages. |
| tests/cases/general/init-idempotent/files/mise.toml | Update Flint self-pin fixture to aqua:grafana/flint. |
| tests/cases/general/flint-setup-unaffected-old-version/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/flint-setup-obsolete-key/test.toml | Update obsolete-key migration expectations for ShellCheck. |
| tests/cases/general/exclude-paths/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/env-var-exclude/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/baseline-tool-upgrade/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/baseline-tool-upgrade/changes/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/baseline-new-linter/changes/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/baseline-flint-upgrade/files/mise.toml | Update ShellCheck + Flint fixtures to new keys. |
| tests/cases/general/baseline-flint-upgrade/changes/mise.toml | Update ShellCheck + Flint fixtures to new keys. |
| tests/cases/general/baseline-flint-settings-change/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/baseline-excluded-config-change/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/baseline-config-change/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/auto-review-unfixable/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/auto-review-two-linters/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| tests/cases/general/auto-fix-and-review/files/mise.toml | Update ShellCheck fixture to bare shellcheck. |
| src/setup.rs | Introduce explicit obsolete key migrations (Flint github:* → aqua:*) and adjust tests. |
| src/registry/tests.rs | Update obsolete-key detection assertions for ShellCheck/xmloxide and README snippet expectations. |
| src/registry/obsolete.rs | Simplify obsolete-key presence logic after reversing ShellCheck migration direction. |
| src/registry/mod.rs | Ensure aqua:grafana/flint is treated as a managed linter key. |
| src/registry/mise.rs | Treat aqua:grafana/flint as a Flint tool key and update alias documentation/example. |
| src/registry/checks.rs | Update canonical mise tool keys and migration sources for shellcheck/xmllint/google-java-format checks. |
| src/readme_snippets.rs | Update quickstart key list to bare shellcheck. |
| src/main.rs | Update embedded tool examples/tests to bare shellcheck. |
| src/init/tests.rs | Update obsolete-key detection tests and normalization expectations for new keys. |
| src/init/scaffold.rs | Bump scaffolded workflow to mise v2026.5.0 with updated SHA256. |
| src/init/mise_tools.rs | Switch Flint self-pin to aqua:grafana/flint and update related tests/logic. |
| src/bin/sync-readme-snippets.rs | Render README snippets using the new canonical tool keys. |
| README.md | Update install and quickstart snippets to aqua:grafana/flint and bare shellcheck. |
| mise.toml | Update repo’s own tool pins to new canonical keys (aqua:*, bare tool names). |
| docs/cli.md | Update docs to refer to aqua:grafana/flint as the pinned Flint key. |
| docs/alternatives.md | Update migration guidance to use bare google-java-format. |
| default.json | Update Renovate grouping metadata to match new tool keys. |
| .github/workflows/test.yml | Bump mise version/SHA256 in CI matrix. |
| .github/workflows/release-plz.yml | Bump mise version/SHA256 in release workflow. |
| .github/workflows/release-assets.yml | Bump mise version/SHA256 in release-assets workflow matrix. |
| .github/workflows/lint.yml | Bump mise version/SHA256 in lint workflow. |
| .github/renovate.json5 | Update README shellcheck regex manager and linter dep grouping to new keys. |
| .github/renovate-tracked-deps.json | Refresh Renovate dependency snapshot to reflect new tool keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github:grafana/flinttoaqua:grafana/flintgithub:koalaman/shellcheckto bareshellcheckgoogle-java-formatfromgithub:google/google-java-formatto baregoogle-java-formatxmloxidefromgithub:jonwiggins/xmloxidetoaqua:jonwiggins/xmloxideflint-setupcan migrate existing repos automaticallymisesetup tov2026.5.0and use the correct standalone binary SHA256 values required byjdx/mise-actionWhy
Recent
miseregistry coverage makes these backend-specific keys unnecessary or outdated for Flint-managed tools. This change moves Flint toward the supported registry/native keys that users should actually have inmise.toml, while keeping migration paths explicit so existing repos can be rewritten by Flint instead of breaking silently.The workflow bump to
mise v2026.5.0is included because that release added thegoogle-java-formatregistry entry needed by this migration. The follow-up checksum fix is included becausejdx/mise-actionverifies the installed standalonemisebinary, not the release archive.Impact
aqua:grafana/flintshellcheck,google-java-format, andaqua:jonwiggins/xmloxideflint run --fix flint-setupflint initscaffolding now usemise v2026.5.0with matching binary checksumsValidation
cargo testmise run lint:fixmise run lint