fix: match mise linter presets by dep name#256
Closed
zeitlinger wants to merge 3 commits intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Renovate “weekly linters” preset/config to match mise tools by depName (instead of packageName), and adjusts the Rust registry drift tests to enforce the updated matcher contract.
Changes:
- Switch the weekly
lintersRenovate rule matcher frommatchPackageNamestomatchDepNames. - Keep
default.jsonand.github/renovate.json5aligned on the same matcher. - Update registry tests to validate
matchDepNamescoverage/sortedness for the weekly linters rule and tighten drift checks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/registry/tests.rs |
Updates tests/helpers to validate matchDepNames for the linters rule and compare repo config vs shared preset. |
default.json |
Changes weekly linters rule to use matchDepNames rather than matchPackageNames. |
.github/renovate.json5 |
Mirrors the shared preset change by switching weekly linters to matchDepNames. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
54a1d1b to
f0d2678
Compare
Member
martincostello
left a comment
There was a problem hiding this comment.
LGTM but there's an unresolved Copilot comment.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Member
Author
|
superceded by #263 |
Member
Author
This PR was more guesswork as how to renovate really works - so #263 actually checks that the renovate rules apply to a dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #253
Summary
lintersRenovate rule to matchmiseshort-name tools bydepNameWhy
miseshort-name tools likelychee,ruff, andrumdlcan extract with adepNamethat matches the key inmise.tomlwhilepackageNameresolves to the upstream repo. Matching the weekly linter preset bypackageNamecan therefore miss valid linter updates.Validation
cargo test default_renovate_preset_covers_all_linter_tools_weeklycargo test repo_renovate_config_stays_aligned_with_shared_preset_contract