Skip to content

fix: match mise linter presets by dep name#256

Closed
zeitlinger wants to merge 3 commits intomainfrom
codex/fix-mise-linter-preset-matching
Closed

fix: match mise linter presets by dep name#256
zeitlinger wants to merge 3 commits intomainfrom
codex/fix-mise-linter-preset-matching

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented Apr 29, 2026

Blocked by #253

Summary

  • switch the weekly linters Renovate rule to match mise short-name tools by depName
  • keep the shared preset and repo-local Renovate config aligned on the same matcher
  • tighten the registry drift tests around the weekly linter preset contract

Why

mise short-name tools like lychee, ruff, and rumdl can extract with a depName that matches the key in mise.toml while packageName resolves to the upstream repo. Matching the weekly linter preset by packageName can therefore miss valid linter updates.

Validation

  • cargo test default_renovate_preset_covers_all_linter_tools_weekly
  • cargo test repo_renovate_config_stays_aligned_with_shared_preset_contract

@zeitlinger zeitlinger marked this pull request as ready for review April 29, 2026 14:50
@zeitlinger zeitlinger requested a review from a team as a code owner April 29, 2026 14:50
Copilot AI review requested due to automatic review settings April 29, 2026 14:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Renovate “weekly linters” preset/config to match mise tools by depName (instead of packageName), and adjusts the Rust registry drift tests to enforce the updated matcher contract.

Changes:

  • Switch the weekly linters Renovate rule matcher from matchPackageNames to matchDepNames.
  • Keep default.json and .github/renovate.json5 aligned on the same matcher.
  • Update registry tests to validate matchDepNames coverage/sortedness for the weekly linters rule and tighten drift checks.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/registry/tests.rs Updates tests/helpers to validate matchDepNames for the linters rule and compare repo config vs shared preset.
default.json Changes weekly linters rule to use matchDepNames rather than matchPackageNames.
.github/renovate.json5 Mirrors the shared preset change by switching weekly linters to matchDepNames.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/registry/tests.rs
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger force-pushed the codex/fix-mise-linter-preset-matching branch from 54a1d1b to f0d2678 Compare April 30, 2026 13:02
Copy link
Copy Markdown
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there's an unresolved Copilot comment.

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
Copy link
Copy Markdown
Member Author

superceded by #263

@zeitlinger zeitlinger closed this May 4, 2026
@zeitlinger
Copy link
Copy Markdown
Member Author

LGTM but there's an unresolved Copilot comment.

This PR was more guesswork as how to renovate really works - so #263 actually checks that the renovate rules apply to a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants