fix(init): enable yamllint indentation rule#251
Merged
zeitlinger merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the generated yamllint configuration to use the canonical indentation: enable rule form (instead of the legacy nested spaces: 2 form) and hardens the generator test to prevent future drift in the generated .github/config/.yamllint.yml.
Changes:
- Update
.yamllint.ymlfixtures to useindentation: enable. - Update the init generator (
generate_yamllint_config) to emitindentation: enable. - Strengthen the generator test to assert the full generated file content exactly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/init/config_files.rs |
Changes yamllint config generation to emit indentation: enable. |
src/init/tests.rs |
Updates test to assert exact .yamllint.yml output, preventing config drift. |
.github/config/.yamllint.yml |
Aligns repo yamllint config with indentation: enable. |
tests/cases/general/init-rust/test.toml |
Updates init-rust golden output to match new generated yamllint config. |
tests/cases/ryl/clean/files/.github/config/.yamllint.yml |
Updates ryl clean fixture to the new indentation rule shape. |
tests/cases/ryl/failure/files/.github/config/.yamllint.yml |
Updates ryl failure fixture to the new indentation rule shape. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converges generated
.github/config/.yamllint.ymlonindentation: enableinstead of the legacy nestedspaces: 2shape.The generator test now asserts the exact generated config so this does not drift back to ad hoc variants.
Validation
cargo test generate_yamllint_config_writes_fileFLINT_CASES=general/init-rust cargo test casesFLINT_CASES=ryl mise exec -- cargo test casesmise run lint:fixmise run lintmise exec -- cargo test --bins -- --skip registry::tests::all_registry_binaries_foundNote: full
cargo test --binsis blocked in this environment by missingdotnet-format.