fix: make flint-setup state-based#249
Closed
zeitlinger wants to merge 1 commit intomainfrom
Closed
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
11a9da8 to
4bf7966
Compare
Member
Author
|
Superceded by #252 |
Member
Author
|
Superseded by #252. The current branch and follow-up state-based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
flint-setupstate-based instead of version-counter-based.flint-setupno longer persists or advancessettings.setup_migration_version. Routine check mode now stays focused on current actionable setup state frommise.toml: obsolete tool-key migrations, unsupported legacy lint tools, missingnodefornpm:backends, and canonical[tools]ordering.flint-setup --fixstill does the heavy lifting for active setup migrations, but only when the current tool state actually activates that migration. In practice this keeps routine checks cheap and unsurprising while still letting a Flint/tool update branch apply the full migration directly.For the markdownlint-era stack, that means fix mode removes the old tool entries and applies the repo cleanup only when those legacy tools are still present in
mise.toml. Ambient stale comments in unrelated repos no longer surface as generic setup drift.This also removes now-vestigial setup migration plumbing:
settings.setup_migration_versionfrom generated and parsedflint.tomlValidation
cargo test flint_setup -- --nocapturecargo test init::tests -- --nocapturecargo test registry -- --nocaptureFLINT_CASES=general/flint-setup cargo test cases -- --nocapturemise run lint:fixmise run lint