fix: run renovate-deps for deleted tracked files#247
Merged
zeitlinger merged 3 commits intomainfrom Apr 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes renovate-deps relevance detection when the only relevant change is the deletion of a file that remains referenced in .github/renovate-tracked-deps.json, ensuring the linter still runs in --fast-only mode.
Changes:
- Preserve deleted paths in git changed-path collection by no longer filtering deletions out of
git diff --name-only. - Update
renovate-depsrelevance logic to use the raw changed-path list (including deletions) and normalize path separators. - Add unit + Unix e2e coverage to validate
renovate-depsruns when a tracked manifest is deleted.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e.rs | Adds a Unix-only e2e test ensuring renovate-deps runs when a tracked manifest (package.json) is deleted. |
| src/linters/renovate_deps.rs | Switches relevance to use changed_paths (supporting deletions) and introduces path normalization; adds unit test for deleted tracked manifest relevance. |
| src/files.rs | Stops excluding deleted files from git diff --name-only results so deleted paths are preserved in changed_paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matt-hensley
approved these changes
Apr 29, 2026
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
997024a to
a4620d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #253
Summary
Fixes adaptive
renovate-depsrelevance when the only relevant change is deleting a file that is still tracked in.github/renovate-tracked-deps.json.The changed-path collection now preserves deleted paths, and
renovate-depsuses the raw changed path list for relevance instead of only existing files.Validation
cargo fmt -- --checkgit diff --checkcargo test renovate_depsFLINT_CASES=renovate-deps/fast-only cargo test casesNote:
FLINT_CASES=renovate-deps cargo test caseswas attempted, but non-fake renovate fixtures needrenovateinstalled onPATH.