Address review comments from PR #1#2
Merged
zeitlinger merged 2 commits intomainfrom Feb 14, 2026
Merged
Conversation
- Remove FIX_JSONC_PRETTIER flag from super-linter.env to fix inconsistency with disabled VALIDATE_JSON_PRETTIER - Add error handling in renovate-deps.py for missing renovate-tracked-deps.json file - Split long EXCLUDED_MANAGERS line in renovate-deps.py into multiple lines for readability - Update CHANGELOG.md to document v0.1.0 release Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses review feedback from PR #1 by fixing configuration inconsistencies, improving error handling and code readability in the renovate-deps script, and documenting the v0.1.0 release in the CHANGELOG.
Changes:
- Removed conflicting
FIX_JSONC_PRETTIER=trueflag from super-linter configuration - Added error handling for missing
.github/renovate-tracked-deps.jsonfile with helpful error message - Improved code formatting by splitting
EXCLUDED_MANAGERSset comprehension across multiple lines
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/config/super-linter.env | Removed conflicting FIX_JSONC_PRETTIER=true flag that contradicted VALIDATE_JSON_PRETTIER=false |
| tasks/lint/renovate-deps.py | Added error handling for missing tracked-deps file and improved code readability by reformatting long line |
| CHANGELOG.md | Documented v0.1.0 release with proper date and comparison URLs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add logic to create renovate-tracked-deps.json when AUTOFIX=true and file doesn't exist - Keep EXCLUDED_MANAGERS on single line per Ruff formatter preference, with linter suppressions Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This was referenced Apr 16, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the review comments from #1:
FIX_JSONC_PRETTIER=truewhich conflicted withVALIDATE_JSON_PRETTIER=falserenovate-deps.pyfor missing.github/renovate-tracked-deps.jsonwith helpful error messageEXCLUDED_MANAGERSline inrenovate-deps.pyinto multiple lines, eliminating need for linter suppressionsTest plan