ring: add GetWithOptions method to adjust per call behavior #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
commented
Jan 3, 2025
56quarters
force-pushed
the
56quarters/sg-replication
branch
2 times, most recently
from
35571f9 to
e17f2cc
Compare
56quarters
commented
Jan 3, 2025
56quarters
commented
Jan 3, 2025
56quarters
force-pushed
the
56quarters/sg-replication
branch
from
6c1dec6 to
7b887a7
Compare
4 tasks
This change adds a new method that accepts 0 or more `Option` instances that modify the behavior of the call. These options can (currently) be used to adjust the replication factor for a particular key or use buffers to avoid excessive allocation. The most notable changes are in the `Ring.findInstancesForKey` method which is the core of the `Ring.Get` method. Instead of keeping track of distinct zones and assuming that only a single instance per zone would ever be returned, we keep a map of the number of instances found in each zone. Part of grafana/mimir#9944
Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/sg-replication
branch
from
7b887a7 to
bf94082
Compare
Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
This change uses the configured replication factor for the ring to determine the number of zones that should exist when zone-aware replication is enabled Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 28, 2025
Pulls in grafana/dskit#632 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 28, 2025
Pulls in grafana/dskit#632 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 30, 2025
* Allow expanded replication set of TSDB blocks on store-gateways This change adds a tenant-specific setting to allow a subset of TSDB blocks to be replicated to more than the configured replication factor (three by default) on store-gateways. * mimir-microservices-mode: Use default store-gateway replication factor * Add grace period to expanded replication time range Much like how block uploads have a grace period, add a grace period when querying with expanded replication to make sure store-gateways have enough time to load blocks before they are queried. Signed-off-by: Nick Pillitteri <[email protected]> * Code review feedback Signed-off-by: Nick Pillitteri <[email protected]> * Apply grace period to max time _and_ upload time. Signed-off-by: Nick Pillitteri <[email protected]> * Don't check upload time in expanded replication Upload time is checked (and blocks within a grace period are ignored) by the query consistency check. Signed-off-by: Nick Pillitteri <[email protected]> * Code review changes Apply grace period to sync instead of querying Signed-off-by: Nick Pillitteri <[email protected]> * Rename feature to "dynamic_replication" Signed-off-by: Nick Pillitteri <[email protected]> * Fix comment about how grace period works Signed-off-by: Nick Pillitteri <[email protected]> * Update comments about dynamic replication grace period Signed-off-by: Nick Pillitteri <[email protected]> * Update to latest dskit commit Signed-off-by: Nick Pillitteri <[email protected]> * Switch to latest dskit main Pulls in grafana/dskit#632 Signed-off-by: Nick Pillitteri <[email protected]> * Code review changes Signed-off-by: Nick Pillitteri <[email protected]> --------- Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change adds a new method that accepts 0 or more
Optioninstances that modify the behavior of the call. These options can (currently) be used to adjust the replication factor for a particular key or use buffers to avoid excessive allocation.The most notable changes are in the
Ring.findInstancesForKeymethod which is the core of theRing.Getmethod. Instead of keeping track of distinct zones and assuming that only a single instance per zone would ever be returned, we keep a map of the number of instances found in each zone.Which issue(s) this PR fixes:
Part of grafana/mimir#9944
Previous attempt #620
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]