Reduced memory allocations by user.ExtractFromGRPCRequest() #502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In Mimir ingesters, 10% of object (and memory) allocations come from gRPC
metadata.FromIncomingContext().metadata.FromIncomingContext()is called in few places, includinguser.ExtractFromGRPCRequest(). The problem ofmetadata.FromIncomingContext()is that it creates a copy of all metadata map, when we only want to lookup a single key.Two years ago,
metadata.ValueFromIncomingContext()was introduced in gRPC golang library exactly for this reason. The function is still marked as experimental but it was left untouched since was introduced 2 years ago. I propose to use it. If it will get removed, we can always revert back tometadata.FromIncomingContext().Benchmark:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]