Remove ring global metrics #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2021 16:55
Signed-off-by: Tyler Reid <[email protected]>
pracucci
reviewed
Oct 6, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Good job! A couple of things to fix/improve and it's good 👏
pracucci
reviewed
Oct 7, 2021
pracucci
approved these changes
Oct 7, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This is a refactor of the global metrics in Lifecycler and Ring in the Ring package. Since this is a shared base library we want to remove all global metrics and allow uses to decide how they want to register metrics. This also allows us to use these metrics in a similar fashion for cortex.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]