Simplify SpreadMinimizingTokenGenerator for easier reuse in partitions ring. #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
commented
Jan 10, 2024
| allTokens, err := t.generateAllTokens() | ||
| if err != nil { | ||
| // we were unable to generate required tokens, so we panic. | ||
| panic(err) |
Contributor
Author
There was a problem hiding this comment.
This panic is not new, it was just moved from generateTokensByInstanceID to this method.
duricanikolic
approved these changes
Jan 10, 2024
Contributor
duricanikolic
left a comment
duricanikolic
left a comment
There was a problem hiding this comment.
LGTM
Before merging could you please check the comment I wrote?
|
|
||
| prevInstance, err := previousInstance(t.instance) | ||
| if err != nil { | ||
| if errors.Is(err, errorNoPreviousInstance) { |
Contributor
There was a problem hiding this comment.
Could you please check whether we still need errorNoPreviousInstance? I think that at this point it should be removed.
Contributor
Author
There was a problem hiding this comment.
This PR removed errorNoPreviousInstance variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR simplifies internals of
SpreadMinimizingTokenGenerator: it removes logger, slice with zones, parsing of instance when computing previous instance.These changes make it easier to reuse this token generator in partitions ring code (https://github.com/grafana/dskit/compare/partitions-ring branch).
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]