In-memory implementation of etcd client for testing - #43
Merged
Conversation
Create an in-memory version of an Etcd v3 client for use testing the Etcd implementation of kv.Client. Because this client is only for unit testing another part of dskit, it does not implement all operations that the real client does - only enough to pass our tests. The benefit of this in-memory client is that dskit can drop its dependency on the entire Etcd server which was used in-process for testing previously. This meant that consumers of dskit inherited a dependency on the Etcd server and all its dependencies which caused version conflicts in e.g. Tempo. Fixes #40 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
replay
reviewed
Sep 16, 2021
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
trevorwhitney
approved these changes
Sep 16, 2021
trevorwhitney
left a comment
trevorwhitney
left a comment
Contributor
There was a problem hiding this comment.
A few small nits, but LGTM! Looks great!
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
replay
reviewed
Sep 17, 2021
replay
reviewed
Sep 17, 2021
replay
reviewed
Sep 17, 2021
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
What this PR does:
Create an in-memory version of an Etcd v3 client for use testing
the Etcd implementation of kv.Client. Because this client is only
for unit testing another part of dskit, it does not implement all
operations that the real client does - only enough to pass our tests.
The benefit of this in-memory client is that dskit can drop its
dependency on the entire Etcd server which was used in-process for
testing previously. This meant that consumers of dskit inherited
a dependency on the Etcd server and all its dependencies which
caused version conflicts in e.g. Tempo.
Which issue(s) this PR fixes:
Fixes #40
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]