memberlist: Fix panics when accessing delegate methods before Starting or calling NotifyMsg during service start #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling NotifyMsg while service was still starting could also panic. This fixes both problems.
ortuman
approved these changes
Dec 15, 2022
Contributor
ortuman
left a comment
ortuman
left a comment
There was a problem hiding this comment.
Thanks for the fix Peter!
Just left a small comment, but in general LGTM. 👍
pracucci
approved these changes
Dec 16, 2022
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Thanks Peter, LGTM! I also think discarding the messages before the delegate is ready is not an issue.
charleskorn
pushed a commit
that referenced
this pull request
Aug 3, 2023
…uests Make debug logs on successful requests from GRPCServerLog optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR changes
memberlist.KVto protect calls to methods from ``memberlist.Delegateinterface. Previously these methods were protected byinitWG` field during KV service starting, but not before.NotifyMsgwas previously protected byinitWGfield too, but this check was removed in #110. In this PR, we re-add the check (usingdelegateReady).Note that under normal conditions clients of
*memberlist.KVare NOT supposed to call these delegate methods. Only memberlist library calls them viamemberlist.Delegateinterface.Which issue(s) this PR fixes:
Fixes problem reported in grafana/mimir#3732.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]