Add faillint paths to reject global prometheus metrics #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Reid <[email protected]>
pracucci
reviewed
Aug 19, 2021
pracucci
previously approved these changes
Aug 19, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM! But we need to get CI passes fixing issues before merging.
Signed-off-by: Tyler Reid <[email protected]>
Contributor
Author
|
Vendor went off, let me fix that |
added 2 commits
August 19, 2021 11:48
This reverts commit 052a84b.
Signed-off-by: Tyler Reid <[email protected]>
aknuds1
requested changes
Aug 20, 2021
Collaborator
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
I think it looks as if there are some typos, dupes in the faillint config?
pracucci
reviewed
Aug 20, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
How are all the functions comments changes related to this PR?
pracucci
dismissed
their stale review
Don't understand why unrelated comments have changed in this PR.
Contributor
Author
|
The comments were failing golang ci lint, so I wanted to fix that with the other linter issues as I went. But you're right, I'll pull it to a different PR since it doesn't make sense here. |
added 2 commits
August 23, 2021 10:33
This reverts commit 64bc82d.
Signed-off-by: Tyler Reid <[email protected]>
aknuds1
requested changes
Aug 25, 2021
Collaborator
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
I think there's duplication in the lint rules.
Merged
Signed-off-by: Tyler Reid <[email protected]>
Contributor
Author
|
Let there be Lint! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers metrics registered with
prometheus.{NewCounter,NewCounterVec,NewCounterVec,NewGauge,NewGaugeVec,NewGaugeFunc,\ NewHistorgram,NewHistogramVec,NewSummary,NewSummaryVec}and will suggest to usepromauto.With()to register metrics to prevent registering of global metrics. We will also fail onprometheus.MustRegister()calls as metrics should be registered automatically with promauto.Signed-off-by: Tyler Reid [email protected]